Bug 25268 – Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint on RenderSVGModelObject

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Eric Seidel (no email)]

Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint on RenderSVGModelObject

Surprisingly this caused improvements in 3 test cases!  I love fixing bugs w/o trying!

[Eric Seidel (no email)]

Created attachment 29579 [details]
        Reviewed by Simon Fraser.


        Remove more dead code from RenderSVGHiddenContainer.

        lineHeight and baselinePosition used to be on RenderSVGContainer
        (of which this is a subclass) because RenderSVGContainer used
        to be a RenderBox and always the renderer for <svg>
        Now <svg> uses RenderSVGRoot when needing a RenderBox (inside HTML)
        and RenderSVGViewportContainer (when inside SVG content)
        so there is no need for RenderSVGHiddenContainer to have these HTML-specific methods.

        * rendering/RenderSVGHiddenContainer.cpp:
        * rendering/RenderSVGHiddenContainer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 1 files changed, 16 insertions(+), 0 deletions(-)

[Eric Seidel (no email)]

Created attachment 29580 [details]
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint

 15 files changed, 111 insertions(+), 57 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 29579 [details]
        Reviewed by Simon Fraser.

Git is confused.

[Eric Seidel (no email)]

I think this also has caused a small improvement to bug 14015.  However, bug 14015 will be fixed (very easily) once all this refactoring is done. :)

[Eric Seidel (no email)]

Created attachment 29581 [details]
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint

 15 files changed, 121 insertions(+), 57 deletions(-)

[Antti Koivisto]

Comment on attachment 29581 [details]
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint

r=me with renaming of m_maximumPaintedRect to something more informative

[Eric Seidel (no email)]

*** Bug 21968 has been marked as a duplicate of this bug. ***

[Eric Seidel (no email)]

*** Bug 20769 has been marked as a duplicate of this bug. ***

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/mac/svg/custom/focus-ring-expected.checksum
	M	LayoutTests/platform/mac/svg/custom/focus-ring-expected.png
	M	LayoutTests/platform/mac/svg/custom/marker-overflow-clip-expected.txt
	M	LayoutTests/platform/mac/svg/custom/scroll-hit-test-expected.checksum
	M	LayoutTests/platform/mac/svg/custom/scroll-hit-test-expected.png
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderPath.cpp
	M	WebCore/rendering/RenderPath.h
	M	WebCore/rendering/RenderSVGContainer.cpp
	M	WebCore/rendering/RenderSVGContainer.h
	M	WebCore/rendering/RenderSVGModelObject.cpp
	M	WebCore/rendering/RenderSVGModelObject.h
	M	WebCore/rendering/RenderSVGRoot.cpp
	M	WebCore/rendering/RenderSVGRoot.h
Committed r42613

YAY!