Bug 25268 - Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint on RenderSVGModelObject
Summary: Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForR...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 20769 21968 (view as bug list)
Depends on:
Blocks: 20769
  Show dependency treegraph
 
Reported: 2009-04-17 09:55 PDT by Eric Seidel (no email)
Modified: 2009-04-17 10:43 PDT (History)
4 users (show)

See Also:


Attachments
Reviewed by Simon Fraser. (1.02 KB, patch)
2009-04-17 09:56 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint (16.56 KB, patch)
2009-04-17 09:56 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint (17.07 KB, patch)
2009-04-17 10:06 PDT, Eric Seidel (no email)
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-04-17 09:55:15 PDT
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint on RenderSVGModelObject

Surprisingly this caused improvements in 3 test cases!  I love fixing bugs w/o trying!
Comment 1 Eric Seidel (no email) 2009-04-17 09:56:00 PDT
Created attachment 29579 [details]
        Reviewed by Simon Fraser.


        Remove more dead code from RenderSVGHiddenContainer.

        lineHeight and baselinePosition used to be on RenderSVGContainer
        (of which this is a subclass) because RenderSVGContainer used
        to be a RenderBox and always the renderer for <svg>
        Now <svg> uses RenderSVGRoot when needing a RenderBox (inside HTML)
        and RenderSVGViewportContainer (when inside SVG content)
        so there is no need for RenderSVGHiddenContainer to have these HTML-specific methods.

        * rendering/RenderSVGHiddenContainer.cpp:
        * rendering/RenderSVGHiddenContainer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 1 files changed, 16 insertions(+), 0 deletions(-)
Comment 2 Eric Seidel (no email) 2009-04-17 09:56:02 PDT
Created attachment 29580 [details]
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint

 15 files changed, 111 insertions(+), 57 deletions(-)
Comment 3 Eric Seidel (no email) 2009-04-17 09:57:24 PDT
Comment on attachment 29579 [details]
        Reviewed by Simon Fraser.

Git is confused.
Comment 4 Eric Seidel (no email) 2009-04-17 10:00:37 PDT
I think this also has caused a small improvement to bug 14015.  However, bug 14015 will be fixed (very easily) once all this refactoring is done. :)
Comment 5 Eric Seidel (no email) 2009-04-17 10:06:51 PDT
Created attachment 29581 [details]
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint

 15 files changed, 121 insertions(+), 57 deletions(-)
Comment 6 Antti Koivisto 2009-04-17 10:17:06 PDT
Comment on attachment 29581 [details]
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint

r=me with renaming of m_maximumPaintedRect to something more informative
Comment 7 Eric Seidel (no email) 2009-04-17 10:28:48 PDT
*** Bug 21968 has been marked as a duplicate of this bug. ***
Comment 8 Eric Seidel (no email) 2009-04-17 10:29:46 PDT
*** Bug 20769 has been marked as a duplicate of this bug. ***
Comment 9 Eric Seidel (no email) 2009-04-17 10:43:29 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/mac/svg/custom/focus-ring-expected.checksum
	M	LayoutTests/platform/mac/svg/custom/focus-ring-expected.png
	M	LayoutTests/platform/mac/svg/custom/marker-overflow-clip-expected.txt
	M	LayoutTests/platform/mac/svg/custom/scroll-hit-test-expected.checksum
	M	LayoutTests/platform/mac/svg/custom/scroll-hit-test-expected.png
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderPath.cpp
	M	WebCore/rendering/RenderPath.h
	M	WebCore/rendering/RenderSVGContainer.cpp
	M	WebCore/rendering/RenderSVGContainer.h
	M	WebCore/rendering/RenderSVGModelObject.cpp
	M	WebCore/rendering/RenderSVGModelObject.h
	M	WebCore/rendering/RenderSVGRoot.cpp
	M	WebCore/rendering/RenderSVGRoot.h
Committed r42613

YAY!