RESOLVED FIXED 25261
Implement DOMWindow.event as a custom binding in V8 
https://bugs.webkit.org/show_bug.cgi?id=25261
Summary Implement DOMWindow.event as a custom binding in V8
Eric Roman
Reported 2009-04-16 21:37:24 PDT
With change <http://trac.webkit.org/changeset/42430>, the "event" attribute got moved into DOMWindow.idl. Before it was coded in JSDOMWindowBase (and in the case of v8 bindings, V8AbstractEventListener). This bug is about updating the V8 bindings to work with the new idl. This change should also fix two flaws in the current V8 bindings on "event": - The "event" attribute should not be exposed to workers (just DOMWindow) - It should be possible to shadow "window.event" Patch coming soon.
Attachments
Move handling of DOMWindow.event to custom getter (4.39 KB, patch)
2009-04-17 13:08 PDT, Eric Roman 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Roman
Comment 1 2009-04-17 13:08:22 PDT
Created attachment 29587 [details] Move handling of DOMWindow.event to custom getter
Dimitri Glazkov (Google)
Comment 2 2009-04-20 08:20:15 PDT
Comment on attachment 29587 [details] Move handling of DOMWindow.event to custom getter Thanks for doing this!
Dimitri Glazkov (Google)
Comment 3 2009-04-20 08:27:51 PDT
Landed as http://trac.webkit.org/changeset/42671.
Note You need to log in before you can comment on or make changes to this bug.