Bug 25260 - Finish V8 custom bindings for InspectorController
Summary: Finish V8 custom bindings for InspectorController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-16 20:58 PDT by Dimitri Glazkov (Google)
Modified: 2009-04-16 21:21 PDT (History)
0 users

See Also:


Attachments
Finish V8 custom bindings for InspectorController. (10.54 KB, patch)
2009-04-16 20:59 PDT, Dimitri Glazkov (Google)
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-04-16 20:58:08 PDT
Now that it's getting unforked, it needs the full bindings.
Comment 1 Dimitri Glazkov (Google) 2009-04-16 20:59:41 PDT
Created attachment 29571 [details]
Finish V8 custom bindings for InspectorController.

 WebCore/ChangeLog                                  |   10 +
 .../v8/custom/V8InspectorControllerCustom.cpp      |  267 +++++++++++++++++++-
 2 files changed, 269 insertions(+), 8 deletions(-)
Comment 2 Darin Fisher (:fishd, Google) 2009-04-16 21:02:39 PDT
Comment on attachment 29571 [details]
Finish V8 custom bindings for InspectorController.

> +++ b/WebCore/bindings/v8/custom/V8InspectorControllerCustom.cpp

> +    Node* node = V8Proxy::DOMWrapperToNode<Node>(args[0]);
> +    if (!node)
> +        return v8::Undefined();
> +
> +   InspectorController* inspectorController = V8Proxy::ToNativeObject<InspectorController>(V8ClassIndex::INSPECTORCONTROLLER, args.Holder());
> +   inspectorController->highlight(node);
> +
> +    return v8::Undefined();
> +}

^^^ indentation is off by one there.

otherwise, LGTM
Comment 3 Dimitri Glazkov (Google) 2009-04-16 21:21:01 PDT
Doh! Fixed and landed as http://trac.webkit.org/changeset/42603.