Bug 25260 – Finish V8 custom bindings for InspectorController

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Dimitri Glazkov (Google)]

Now that it's getting unforked, it needs the full bindings.

[Dimitri Glazkov (Google)]

Created attachment 29571 [details]
Finish V8 custom bindings for InspectorController.

 WebCore/ChangeLog                                  |   10 +
 .../v8/custom/V8InspectorControllerCustom.cpp      |  267 +++++++++++++++++++-
 2 files changed, 269 insertions(+), 8 deletions(-)

[Darin Fisher (:fishd, Google)]

Comment on attachment 29571 [details]
Finish V8 custom bindings for InspectorController.

> +++ b/WebCore/bindings/v8/custom/V8InspectorControllerCustom.cpp

> +    Node* node = V8Proxy::DOMWrapperToNode<Node>(args[0]);
> +    if (!node)
> +        return v8::Undefined();
> +
> +   InspectorController* inspectorController = V8Proxy::ToNativeObject<InspectorController>(V8ClassIndex::INSPECTORCONTROLLER, args.Holder());
> +   inspectorController->highlight(node);
> +
> +    return v8::Undefined();
> +}

^^^ indentation is off by one there.

otherwise, LGTM

[Dimitri Glazkov (Google)]

Doh! Fixed and landed as http://trac.webkit.org/changeset/42603.