Bug 25259 – AX: VoiceOver cmd-cntl-space does not follow the google.com->more link

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

The more link in google.com does not change the AXChildren and show the now visible links

[chris fleizach]

Created attachment 29569 [details]
patch to fix accessibility problem with invisible elements

[Darin Adler]

Comment on attachment 29569 [details]
patch to fix accessibility problem with invisible elements

> +            bool visibilityChanged = (m_style->visibility() != newStyle->visibility() ||
> +                                            m_style->zIndex() != newStyle->zIndex() ||
> +                                            m_style->hasAutoZIndex() != newStyle->hasAutoZIndex());

The formatting here retains strange indenting and parentheses from the if statement. I would use this format:

    bool visibilityChanged = m_style->visibility() != newStyle->visibility()
        || m_style->zIndex() != newStyle->zIndex()
        || m_style->hasAutoZIndex() != newStyle->hasAutoZIndex();

Partly this is because I prefer the "operators at beginning of line" style because I think it makes it clearer that subsequent lines are continuations of the expression. And partly because I think the entire expression is easier to read if we don't do excessive indentation.

r=me

[chris fleizach]

http://trac.webkit.org/changeset/42611