Bug 25259 - AX: VoiceOver cmd-cntl-space does not follow the google.com->more link
: AX: VoiceOver cmd-cntl-space does not follow the google.com->more link
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Accessibility
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-16 18:30 PDT by chris fleizach
Modified: 2009-04-17 09:00 PDT (History)
0 users

See Also:


Attachments
patch to fix accessibility problem with invisible elements (4.69 KB, patch)
2009-04-16 19:31 PDT, chris fleizach
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2009-04-16 18:30:33 PDT
The more link in google.com does not change the AXChildren and show the now visible links
Comment 1 chris fleizach 2009-04-16 19:31:45 PDT
Created attachment 29569 [details]
patch to fix accessibility problem with invisible elements
Comment 2 Darin Adler 2009-04-17 05:17:12 PDT
Comment on attachment 29569 [details]
patch to fix accessibility problem with invisible elements

> +            bool visibilityChanged = (m_style->visibility() != newStyle->visibility() ||
> +                                            m_style->zIndex() != newStyle->zIndex() ||
> +                                            m_style->hasAutoZIndex() != newStyle->hasAutoZIndex());

The formatting here retains strange indenting and parentheses from the if statement. I would use this format:

    bool visibilityChanged = m_style->visibility() != newStyle->visibility()
        || m_style->zIndex() != newStyle->zIndex()
        || m_style->hasAutoZIndex() != newStyle->hasAutoZIndex();

Partly this is because I prefer the "operators at beginning of line" style because I think it makes it clearer that subsequent lines are continuations of the expression. And partly because I think the entire expression is easier to read if we don't do excessive indentation.

r=me
Comment 3 chris fleizach 2009-04-17 09:00:36 PDT
http://trac.webkit.org/changeset/42611