RESOLVED FIXED 252383
[GLib] WebKitPermissionRequest should use G_DECLARE_INTERFACE in 2022 API 
https://bugs.webkit.org/show_bug.cgi?id=252383
Summary [GLib] WebKitPermissionRequest should use G_DECLARE_INTERFACE in 2022 API
Adrian Perez
Reported 2023-02-16 00:54:13 PST
Somewhat related to bug #243663, now that we have WEBKIT_DECLARE{,_DERIVABLE,_FINAL}_TYPE then the WebKitPermissionRequest type should also use the new macros to cut on the manual boilerplate.
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2023-02-16 01:09:31 PST
Correction: it is an interface, so we want to use a new macro i.e. WEBKIT_DECLARE_INTERFACE that forwards most of the work to G_DECLARE_INTERFACE. Amusingly, the implementation is already using G_DEFINE_INTERFACE.
Adrian Perez
Comment 2 2023-02-16 07:47:33 PST
Given that WebKitPermissionRequest is the only interface defined in the API, I plan to skip making a WEBKIT_DEFINE_INTERFACE macro and put directly an expansion of G_DECLARE_INTERFACE in the header. Also, it's not like we want to do much other than what G_DECLARE_INTERFACE does anyway, so it does not seem worth the effort to maintain a new macro inside WebKit :)
Adrian Perez
Comment 3 2023-02-16 07:51:11 PST
Pull request: https://github.com/WebKit/WebKit/pull/10200
EWS
Comment 4 2023-02-16 16:05:33 PST
Committed 260403@main (10d6f8608be4): <https://commits.webkit.org/260403@main> Reviewed commits have been landed. Closing PR #10200 and removing active labels.
Radar WebKit Bug Importer
Comment 5 2023-02-16 16:06:42 PST
<rdar://problem/105569323>
Note You need to log in before you can comment on or make changes to this bug.