Bug 252361 - Update parserSetAttributes() to take in a Span instead of a Vector
Summary: Update parserSetAttributes() to take in a Span instead of a Vector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-15 16:24 PST by Chris Dumez
Modified: 2023-02-15 20:47 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-02-15 16:24:02 PST 
Update parserSetAttributes() to take in a Span instead of a Vector.
Its implementation doesn't require a Vector, a Span suffices. Using a Span has a couple of benefits:
1. It allows some call sites to not create a Vector at all to set a single attribute
2. It allows call sites to use Vectors that can have various inline capacities
Comment 1 Chris Dumez 2023-02-15 16:25:37 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10178
Comment 2 EWS 2023-02-15 20:46:26 PST 
Committed 260349@main (7ee416a7a42e): <https://commits.webkit.org/260349@main>

Reviewed commits have been landed. Closing PR #10178 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-02-15 20:47:18 PST 
<rdar://problem/105530074>