RESOLVED FIXED 252323
[margin-trim] Change shouldChildInlineMarginContributeToContainerIntrinsicSize to be a virtual method on RenderBlock 
https://bugs.webkit.org/show_bug.cgi?id=252323
Summary [margin-trim] Change shouldChildInlineMarginContributeToContainerIntrinsicSiz...
Sammy Gill
Reported 2023-02-15 10:02:34 PST
It is a little strange in the way that we currently use this method (immediately downcast to RenderBlockFlow). It would be a better interface if it was a virtual method on RenderBlock and gets overridden in RenderBlockFlow
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-02-15 10:03:00 PST
<rdar://problem/105502226>
Sammy Gill
Comment 2 2023-02-25 20:15:47 PST
Pull request: https://github.com/WebKit/WebKit/pull/10690
EWS
Comment 3 2023-02-26 08:18:29 PST
Committed 260850@main (cc5d15ac506b): <https://commits.webkit.org/260850@main> Reviewed commits have been landed. Closing PR #10690 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.