Bug 252279 - [IFC][Partial layout] Compute damage extent when appending text content
Summary: [IFC][Partial layout] Compute damage extent when appending text content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-14 18:07 PST by zalan
Modified: 2023-02-16 21:37 PST (History)
7 users (show)

See Also:

Attachments
Patch (9.87 KB, patch)
2023-02-14 18:38 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.94 KB, patch)
2023-02-16 15:15 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (1.47 KB, patch)
2023-02-16 20:29 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq] build fix (2.11 KB, patch)
2023-02-16 21:20 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-02-14 18:07:13 PST 
ssia
Comment 1 zalan 2023-02-14 18:38:01 PST 
Created attachment 464992 [details]
Patch
Comment 2 zalan 2023-02-16 15:15:30 PST 
Created attachment 465036 [details]
Patch
Comment 3 EWS 2023-02-16 17:14:57 PST 
Committed 260407@main (df7677f05993): <https://commits.webkit.org/260407@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465036 [details].
Comment 4 Radar WebKit Bug Importer 2023-02-16 17:15:20 PST 
<rdar://problem/105572646>
Comment 5 Ross Kirsling 2023-02-16 19:21:24 PST 
This does not build on Windows:

> layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(62): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t'
> layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(61): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t'
Comment 6 zalan 2023-02-16 20:05:34 PST 
(In reply to Ross Kirsling from comment #5)
> This does not build on Windows:
> 
> > layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(62): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t'
> > layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(61): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t'
:( sorry about that. should have paid attention to the red bubble.
Comment 7 zalan 2023-02-16 20:29:44 PST 
Created attachment 465041 [details]
[fast-cq]Patch

Build fix.
Comment 8 zalan 2023-02-16 20:30:35 PST 
broke the build.
Comment 9 Fujii Hironori 2023-02-16 20:32:46 PST 
WinCairo EWS waiting queue is long since the build failure. I confirmed your patch fixes WinCairo build. Thank you.
Comment 10 zalan 2023-02-16 20:48:43 PST 
(In reply to Fujii Hironori from comment #9)
> WinCairo EWS waiting queue is long since the build failure. I confirmed your
> patch fixes WinCairo build. Thank you.
Thank you for confirming it. let me [fast-cq]+ it!
Comment 11 Fujii Hironori 2023-02-16 21:20:17 PST 
Created attachment 465042 [details]
[fast-cq] build fix
Comment 12 zalan 2023-02-16 21:21:15 PST 
(In reply to Fujii Hironori from comment #11)
> Created attachment 465042 [details]
> [fast-cq] Patch
:( thanks.
Comment 13 EWS 2023-02-16 21:29:52 PST 
Committed 260421@main (7ba52be59233): <https://commits.webkit.org/260421@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465042 [details].