RESOLVED FIXED252236
[WPE] Build broken with external holepunch enabled 
https://bugs.webkit.org/show_bug.cgi?id=252236
Summary [WPE] Build broken with external holepunch enabled
Miguel Gomez
Reported 2023-02-14 01:53:44 PST
There are 2 build errors: - MediaPlayerPrivate::setSize(), which is overridden by MediaPlayerPrivateHolePunch::setSize() was renamed to MediaPlayerPrivate::setPresentationSize(), so the one in MediaPlayerPrivateHolePunch must be renamed too. - The String class constructor that receives a char* is now private, so we need to use a different way to create the mime type Strings.
Attachments
Add attachment proposed patch, testcase, etc.
Miguel Gomez
Comment 1 2023-02-14 02:16:33 PST
Pull request: https://github.com/WebKit/WebKit/pull/10082
EWS
Comment 2 2023-02-14 03:57:17 PST
Committed 260251@main (38f8a723a95d): <https://commits.webkit.org/260251@main> Reviewed commits have been landed. Closing PR #10082 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.