Bug 25221 - SVG renderers should share a base class, like how CSS Box model renderers do
: SVG renderers should share a base class, like how CSS Box model renderers do
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: SVG
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-15 15:13 PDT by Eric Seidel
Modified: 2009-04-15 15:32 PDT (History)
0 users

See Also:


Attachments
Add minimal RenderSVGModelObject (14.89 KB, patch)
2009-04-15 15:14 PDT, Eric Seidel
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel 2009-04-15 15:13:32 PDT
SVG renderers should share a base class, like how CSS Box model renderers do

RenderSVGModelObject (named after RenderBoxModelObject) is said new class.

This first patch will just add the basic plumbing.  Future patches will add actual logic to this class.
Comment 1 Eric Seidel 2009-04-15 15:14:29 PDT
Created attachment 29518 [details]
Add minimal RenderSVGModelObject

 WebCore/ChangeLog                          |   30 ++++++++++++++
 WebCore/WebCore.pro                        |    1 +
 WebCore/WebCore.scons                      |    1 +
 WebCore/WebCore.vcproj/WebCore.vcproj      |    8 ++++
 WebCore/WebCore.xcodeproj/project.pbxproj  |    8 ++++
 WebCore/rendering/RenderPath.cpp           |    3 +-
 WebCore/rendering/RenderPath.h             |    9 ++--
 WebCore/rendering/RenderSVGContainer.cpp   |    2 +-
 WebCore/rendering/RenderSVGContainer.h     |    6 +--
 WebCore/rendering/RenderSVGModelObject.cpp |   46 ++++++++++++++++++++++
 WebCore/rendering/RenderSVGModelObject.h   |   57 ++++++++++++++++++++++++++++
 WebCore/rendering/RenderTreeAsText.cpp     |    1 +
 WebCore/rendering/SVGRenderTreeAsText.cpp  |    1 +
 13 files changed, 161 insertions(+), 12 deletions(-)
Comment 2 Oliver Hunt 2009-04-15 15:19:38 PDT
Comment on attachment 29518 [details]
Add minimal RenderSVGModelObject

why are SVGRenderTreeAsText and RenderTreeAsText getting a new include?
Comment 3 Simon Fraser (smfr) 2009-04-15 15:26:32 PDT
Comment on attachment 29518 [details]
Add minimal RenderSVGModelObject

r=me, though you may want to use the 2-clause BDS license.
Comment 4 Eric Seidel 2009-04-15 15:30:30 PDT
(In reply to comment #2)
> (From update of attachment 29518 [details] [review])
> why are SVGRenderTreeAsText and RenderTreeAsText getting a new include?
> 

They got a new include because I removed the unneeded include from RednerSVGContainer.
Comment 5 Eric Seidel 2009-04-15 15:32:29 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.pro
	M	WebCore/WebCore.scons
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/rendering/RenderPath.cpp
	M	WebCore/rendering/RenderPath.h
	M	WebCore/rendering/RenderSVGContainer.cpp
	M	WebCore/rendering/RenderSVGContainer.h
	A	WebCore/rendering/RenderSVGModelObject.cpp
	A	WebCore/rendering/RenderSVGModelObject.h
	M	WebCore/rendering/RenderTreeAsText.cpp
	M	WebCore/rendering/SVGRenderTreeAsText.cpp
Committed r42561