SVG renderers should share a base class, like how CSS Box model renderers do RenderSVGModelObject (named after RenderBoxModelObject) is said new class. This first patch will just add the basic plumbing. Future patches will add actual logic to this class.
Created attachment 29518 [details] Add minimal RenderSVGModelObject WebCore/ChangeLog | 30 ++++++++++++++ WebCore/WebCore.pro | 1 + WebCore/WebCore.scons | 1 + WebCore/WebCore.vcproj/WebCore.vcproj | 8 ++++ WebCore/WebCore.xcodeproj/project.pbxproj | 8 ++++ WebCore/rendering/RenderPath.cpp | 3 +- WebCore/rendering/RenderPath.h | 9 ++-- WebCore/rendering/RenderSVGContainer.cpp | 2 +- WebCore/rendering/RenderSVGContainer.h | 6 +-- WebCore/rendering/RenderSVGModelObject.cpp | 46 ++++++++++++++++++++++ WebCore/rendering/RenderSVGModelObject.h | 57 ++++++++++++++++++++++++++++ WebCore/rendering/RenderTreeAsText.cpp | 1 + WebCore/rendering/SVGRenderTreeAsText.cpp | 1 + 13 files changed, 161 insertions(+), 12 deletions(-)
Comment on attachment 29518 [details] Add minimal RenderSVGModelObject why are SVGRenderTreeAsText and RenderTreeAsText getting a new include?
Comment on attachment 29518 [details] Add minimal RenderSVGModelObject r=me, though you may want to use the 2-clause BDS license.
(In reply to comment #2) > (From update of attachment 29518 [details] [review]) > why are SVGRenderTreeAsText and RenderTreeAsText getting a new include? > They got a new include because I removed the unneeded include from RednerSVGContainer.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCore.pro M WebCore/WebCore.scons M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/rendering/RenderPath.cpp M WebCore/rendering/RenderPath.h M WebCore/rendering/RenderSVGContainer.cpp M WebCore/rendering/RenderSVGContainer.h A WebCore/rendering/RenderSVGModelObject.cpp A WebCore/rendering/RenderSVGModelObject.h M WebCore/rendering/RenderTreeAsText.cpp M WebCore/rendering/SVGRenderTreeAsText.cpp Committed r42561