Bug 252183 - [margin-trim] Floats with trimmed margins in block layout are being positioned incorrectly
Summary: [margin-trim] Floats with trimmed margins in block layout are being positione...
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-13 12:35 PST by Sammy Gill
Modified: 2023-10-17 10:01 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-02-13 12:35:42 PST 
It seems like at least in certain cases floats are not being marked as dirty when going through layout again. \

imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-overflowing-float-margins-tirmmed-at-final-position-block-layout.html showcases this behavior

During the first layout the float gets its correct position, but then when a second layout occurs it gets placed incorrectly since it was not dirtied and did not go through layout again
Comment 1 Radar WebKit Bug Importer 2023-02-13 12:36:05 PST 
<rdar://problem/105410985>
Comment 2 Sammy Gill 2023-03-07 13:57:05 PST 
Pull request: https://github.com/WebKit/WebKit/pull/11187
Comment 3 Sammy Gill 2023-10-17 10:01:27 PDT 
This part of the spec was removed by the CSSWG and will potentially be explored later in a future version of the spec. As a result, this issue no longer applies at this time.