WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
25218
Remove an "inline" keyword from method definition
https://bugs.webkit.org/show_bug.cgi?id=25218
Summary
Remove an "inline" keyword from method definition
Eric Roman
Reported
2009-04-15 13:20:42 PDT
I want to remove the "inline" keyword from DOMWindow::inlineEventListenerForType. My c++ foo isn't that strong, but I think using inline in the definition only works if the method isn't referenced externally. (And in this case, chromium references this method causing a compile failure on linux). Removal of "inline" is consistent with a similar recent change:
http://trac.webkit.org/changeset/42450
Patch coming soon.
Attachments
Remove an inline keyword.
(1.10 KB, patch)
2009-04-15 13:23 PDT
,
Eric Roman
ap
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Roman
Comment 1
2009-04-15 13:23:38 PDT
Created
attachment 29514
[details]
Remove an inline keyword.
Alexey Proskuryakov
Comment 2
2009-04-16 13:00:46 PDT
Comment on
attachment 29514
[details]
Remove an inline keyword. r=me
Darin Fisher (:fishd, Google)
Comment 3
2009-04-16 15:13:15 PDT
Landed as:
http://trac.webkit.org/changeset/42593
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug