Bug 25218 - Remove an "inline" keyword from method definition
Summary: Remove an "inline" keyword from method definition
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Eric Roman
Depends on:
Reported: 2009-04-15 13:20 PDT by Eric Roman
Modified: 2009-04-16 15:13 PDT (History)
0 users

See Also:

Remove an inline keyword. (1.10 KB, patch)
2009-04-15 13:23 PDT, Eric Roman
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Roman 2009-04-15 13:20:42 PDT
I want to remove the "inline" keyword from DOMWindow::inlineEventListenerForType.

My c++ foo isn't that strong, but I think using inline in the definition only works if the method isn't referenced externally. (And in this case, chromium references this method causing a compile failure on linux).

Removal of "inline" is consistent with a similar recent change:


Patch coming soon.
Comment 1 Eric Roman 2009-04-15 13:23:38 PDT
Created attachment 29514 [details]
Remove an inline keyword.
Comment 2 Alexey Proskuryakov 2009-04-16 13:00:46 PDT
Comment on attachment 29514 [details]
Remove an inline keyword.

Comment 3 Darin Fisher (:fishd, Google) 2009-04-16 15:13:15 PDT
Landed as:  http://trac.webkit.org/changeset/42593