Bug 252137 - [Image Set]: Refactor CSSImageSetValue to accept optional resolution and MIME type parameters
Summary: [Image Set]: Refactor CSSImageSetValue to accept optional resolution and MIME...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Reno
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-12 12:37 PST by Ryan Reno
Modified: 2023-02-27 08:14 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Reno 2023-02-12 12:37:39 PST 
CSS Images level 4 defines image-set to take three arguments - a required image, an optional resolution, and an optional MIME type. The current implementation works for the pre-standardization -webkit-image-set but is awkward to use with the standardized version with its optional arguments.
Comment 1 Radar WebKit Bug Importer 2023-02-12 12:37:55 PST 
<rdar://problem/105367742>
Comment 2 Ryan Reno 2023-02-12 13:04:49 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10002
Comment 3 Ryan Reno 2023-02-13 19:13:35 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10069
Comment 4 EWS 2023-02-23 12:23:12 PST 
Committed 260760@main (f9b1ad4c0847): <https://commits.webkit.org/260760@main>

Reviewed commits have been landed. Closing PR #10069 and removing active labels.