Bug 25213 – ASSERT during Inspector destruction

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Eric Seidel (no email)]

ASSERTION FAILED: !m_page || (m_page && !m_page->parentInspectorController())

I had opened:
http://www.carto.net/papers/svg/samples/canvas.shtml
brought up the inspector by clicking on the image of austria.
Then i right-clicked on the image of austria again, and selected "open in new window"
The window opened with just the image (not the SVG as I had expected!)
So I closed the window, and then right-clicked on the SVG again, and Safari crashed:

(/Users/eseidel/Projects/WebKit/WebCore/inspector/InspectorController.cpp:201 virtual 
0   com.apple.WebCore             	0x039266db WebCore::InspectorController::~InspectorController() + 343
1   com.apple.WebCore             	0x03a0a65d WTF::RefCounted<WebCore::InspectorController>::deref() + 53 (RefCounted.h:94)
2   com.apple.WebCore             	0x03a0a6a6 WTF::RefPtr<WebCore::InspectorController>::~RefPtr() + 34
3   com.apple.WebCore             	0x03a0a301 WebCore::JSInspectorController::~JSInspectorController() + 107
4   com.apple.JavaScriptCore      	0x00660c2b unsigned long JSC::Heap::sweep<(JSC::HeapType)0>() + 181 (Collector.cpp:901)
5   com.apple.JavaScriptCore      	0x005ce1e0 JSC::Heap::collect() + 676 (Collector.cpp:999)
6   com.apple.WebCore             	0x0384502f WebCore::GCController::gcTimerFired(WebCore::Timer<WebCore::GCController>*) + 43 (GCController.cpp:74)WebCore::InspectorController::~InspectorController())

[Eric Seidel (no email)]

Created attachment 29505 [details]
full stack trace

[Adam Roben (:aroben)]

Here's how I can reproduce this in Safari for Windows:

1. Open a tab and load a page
2. Inspect something
3. Close the tab while the Inspector is still open

[Dimitri Glazkov (Google)]

Looking.

[Dimitri Glazkov (Google)]

I can't repro on Mac :( Will try Win tomorrow.

[Dimitri Glazkov (Google)]

BTW, if anyone has good repro steps for Mac, pls let me know.

[Alexey Proskuryakov]

I've just reproduced this on Mac:
1. Open a new window, type about:blank in address bar, hit Enter.
2. Open Web Inspector.
3. Close the about:blank window.

Results in console:

file:///Users/ap/Safari/OpenSource/WebKitBuild/Debug/WebCore.framework/Resources/inspector/ScriptsPanel.js:388: JS ERROR: 
file:///Users/ap/Safari/OpenSource/WebKitBuild/Debug/WebCore.framework/Resources/inspector/ScriptsPanel.js:388: JS ERROR: 
file:///Users/ap/Safari/OpenSource/WebKitBuild/Debug/WebCore.framework/Resources/inspector/ElementsPanel.js:59: JS ERROR: 
file:///Users/ap/Safari/OpenSource/WebKitBuild/Debug/WebCore.framework/Resources/inspector/inspector.js:394: JS ERROR: ReferenceError: Can't find variable: InspectorController
ASSERTION FAILED: !m_page || (m_page && !m_page->parentInspectorController())
(/Users/ap/Safari/OpenSource/WebCore/inspector/InspectorController.cpp:202 virtual WebCore::InspectorController::~InspectorController())

[Dimitri Glazkov (Google)]

Created attachment 30192 [details]
Fix assert during Inspector destruction, v1.

 WebCore/ChangeLog                         |   12 ++++++++++++
 WebCore/inspector/InspectorController.cpp |    8 +++++---
 2 files changed, 17 insertions(+), 3 deletions(-)

[Dimitri Glazkov (Google)]

Landed as http://trac.webkit.org/changeset/43500.