Bug 252052 - [GLib] Add more padding to more vtables
Summary: [GLib] Add more padding to more vtables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2023-02-10 05:24 PST by Michael Catanzaro
Modified: 2023-02-16 14:07 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-02-10 05:24:47 PST 
I forgot that WebKitPolicyDecision must be derivable. Although we're not very likely to ever use it, this vtable should still have more padding, just in case.
Comment 1 Michael Catanzaro 2023-02-10 05:39:33 PST 
In addition to _WebKitPolicyDecisionClass, there is also JSCClassVTable. Another one that is probably not likely to grow beyond its current padding, but we should be cautious nonetheless.
Comment 2 Michael Catanzaro 2023-02-15 12:51:12 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10163
Comment 3 EWS 2023-02-16 14:07:56 PST 
Committed 260396@main (7ca0c691aba6): <https://commits.webkit.org/260396@main>

Reviewed commits have been landed. Closing PR #10163 and removing active labels.