Bug 25201 – Add ScriptFunctionCall/ScriptObject for V8

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Dimitri Glazkov (Google)]

This is all part of the unforking effort for InspectorController

[Dimitri Glazkov (Google)]

Created attachment 29488 [details]
Add ScriptFunctionCall/ScriptObject for V8, v1.

 WebCore/ChangeLog                              |   23 ++++
 WebCore/bindings/v8/ScriptFunctionCall.cpp     |  168 ++++++++++++++++++++++++
 WebCore/bindings/v8/ScriptFunctionCall.h       |   70 ++++++++++
 WebCore/bindings/v8/ScriptObject.cpp           |  139 ++++++++++++++++++++
 WebCore/bindings/v8/ScriptObject.h             |   72 ++++++++++
 WebCore/bindings/v8/ScriptObjectQuarantine.cpp |  102 ++++++++++++++
 WebCore/bindings/v8/ScriptObjectQuarantine.h   |   60 +++++++++
 WebCore/bindings/v8/ScriptScope.cpp            |   67 ++++++++++
 WebCore/bindings/v8/ScriptScope.h              |   57 ++++++++
 WebCore/bindings/v8/ScriptState.cpp            |   50 +++++++
 WebCore/bindings/v8/ScriptState.h              |   11 ++
 WebCore/bindings/v8/ScriptString.h             |    1 +
 WebCore/bindings/v8/ScriptValue.h              |    5 +
 13 files changed, 825 insertions(+), 0 deletions(-)

[Darin Fisher (:fishd, Google)]

Comment on attachment 29488 [details]
Add ScriptFunctionCall/ScriptObject for V8, v1.

> +++ b/WebCore/bindings/v8/ScriptObject.cpp
...
> +#include "config.h"
> +#include "ScriptObject.h"
> +#include "ScriptScope.h"
> +#include "ScriptState.h"

nit: insert newline after ScriptObject.h


> +++ b/WebCore/bindings/v8/ScriptObject.h
...
> +    class ScriptObject : public ScriptValue {
...
> +        static ScriptObject createNew(ScriptState*);

nit: isn't it more common to just call a function like this "create" instead?


> +++ b/WebCore/bindings/v8/ScriptObjectQuarantine.cpp
...
> +bool getQuarantinedScriptObject(Database* database, ScriptObject& quarantinedObject)
> +{
> +    ASSERT(database);
> +
> +    // FIXME: Implement when Database V8 bindings are enabled

nit: maybe add an ASSERT_NOT_REACHED?


> +    // FIXME: Implement when DOM Storage V8 bindings are enabled

ditto


LGTM

[Dimitri Glazkov (Google)]

Comments addressed, landed as http://trac.webkit.org/changeset/42568.