WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 251977
[GTK4] Enable threaded rendering again using 1 painting thread by default
https://bugs.webkit.org/show_bug.cgi?id=251977
Summary
[GTK4] Enable threaded rendering again using 1 painting thread by default
Carlos Garcia Campos
Reported
2023-02-09 01:05:43 PST
It seems the issues with threaded rendering were actually caused by using multiple painting threads, but we can still use a single thread to move the painting off the main thread.
Attachments
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2023-02-09 01:09:29 PST
Pull request:
https://github.com/WebKit/WebKit/pull/9854
EWS
Comment 2
2023-02-09 04:09:21 PST
Committed
260059@main
(4af5eb3490da): <
https://commits.webkit.org/260059@main
> Reviewed commits have been landed. Closing PR #9854 and removing active labels.
Michael Catanzaro
Comment 3
2023-02-09 04:12:50 PST
Maybe should also change: WTFLogAlways("The number of Nicosia painting threads is not between 1 and 8. Using the default value 4\n"); numThreads = 4;
Michael Catanzaro
Comment 4
2023-02-09 04:13:20 PST
Why can't WPE use one thread?
Carlos Garcia Campos
Comment 5
2023-02-09 04:32:07 PST
WPE doesn't enable threaded rendering by default.
Carlos Garcia Campos
Comment 6
2023-02-09 04:32:46 PST
The default is 4, for GTK we use 1 which is not the default value.
Michael Catanzaro
Comment 7
2023-02-09 04:56:28 PST
Just kind of weird for the "default" to be 4 when GTK uses 1 and WPE uses 0 and nothing uses 4. Whatever.
Michael Catanzaro
Comment 8
2023-02-28 13:59:52 PST
I think this was not safe to do after all. See
bug #247628
and
bug #253108
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug