Bug 251977 - [GTK4] Enable threaded rendering again using 1 painting thread by default
Summary: [GTK4] Enable threaded rendering again using 1 painting thread by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks: GTK4
  Show dependency treegraph
 
Reported: 2023-02-09 01:05 PST by Carlos Garcia Campos
Modified: 2023-04-25 08:04 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-02-09 01:05:43 PST
It seems the issues with threaded rendering were actually caused by using multiple painting threads, but we can still use a single thread to move the painting off the main thread.
Comment 1 Carlos Garcia Campos 2023-02-09 01:09:29 PST
Pull request: https://github.com/WebKit/WebKit/pull/9854
Comment 2 EWS 2023-02-09 04:09:21 PST
Committed 260059@main (4af5eb3490da): <https://commits.webkit.org/260059@main>

Reviewed commits have been landed. Closing PR #9854 and removing active labels.
Comment 3 Michael Catanzaro 2023-02-09 04:12:50 PST
Maybe should also change:

WTFLogAlways("The number of Nicosia painting threads is not between 1 and 8. Using the default value 4\n");
numThreads = 4;
Comment 4 Michael Catanzaro 2023-02-09 04:13:20 PST
Why can't WPE use one thread?
Comment 5 Carlos Garcia Campos 2023-02-09 04:32:07 PST
WPE doesn't enable threaded rendering by default.
Comment 6 Carlos Garcia Campos 2023-02-09 04:32:46 PST
The default is 4, for GTK we use 1 which is not the default value.
Comment 7 Michael Catanzaro 2023-02-09 04:56:28 PST
Just kind of weird for the "default" to be 4 when GTK uses 1 and WPE uses 0 and nothing uses 4. Whatever.
Comment 8 Michael Catanzaro 2023-02-28 13:59:52 PST
I think this was not safe to do after all. See bug #247628 and bug #253108.