Bug 25193 - rangeFromLocationAndLength may set a Range endpoint to a non-range compliant Position
Summary: rangeFromLocationAndLength may set a Range endpoint to a non-range compliant ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Justin Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-14 17:11 PDT by Justin Garcia
Modified: 2022-12-16 16:46 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Garcia 2009-04-14 17:11:34 PDT 
TextIterator::rangeFromLocationAndLength does:

Position runEnd = VisiblePosition(runStart).next().deepEquivalent();
if (runEnd.isNotNull()) {
    ExceptionCode ec = 0;
    textRunRange->setEnd(runEnd.node(), runEnd.m_offset, ec);
    ASSERT(!ec);
}

runEnd may not be Range compliant.
Comment 1 Ahmad Saleem 2022-12-16 16:46:50 PST 
I am only able to find "rangeFromLocationAndLength" in three files:

Internals.cpp ; Internals.h ; CompositeEditCommand.cpp

For the last, it was in the comment.

Further, this commit delete this function - https://github.com/WebKit/WebKit/commit/b19656cfb6c28634404b0f8f9ccaf553638bedb5

Do we need to keep this open? Thanks!