Bug 25192 - Make DOMWindow:: inlineEventListenerForType public
Summary: Make DOMWindow:: inlineEventListenerForType public
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Eric Roman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-14 17:08 PDT by Eric Roman
Modified: 2009-04-15 11:13 PDT (History)
2 users (show)

See Also:


Attachments
Make 2 methods on DOMWindow public (1.33 KB, patch)
2009-04-14 17:23 PDT, Eric Roman
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Roman 2009-04-14 17:08:17 PDT
I would like to make these methods of DOMWindow public (currently private):

        void removeInlineEventListenerForType(const AtomicString& eventType);
        EventListener* inlineEventListenerForType(const AtomicString& eventType) 

These used to be public, and live in Document. They were moved in <http://trac.webkit.org/changeset/42446>. This change broke chromium which uses the methods in <http://src.chromium.org/viewvc/chrome/trunk/src/webkit/port/bindings/v8/v8_custom.cpp>.

By making the renamed methods public again, I can easily update v8_custom.cpp to build again.

Will attach a patch.
Comment 1 Eric Roman 2009-04-14 17:23:11 PDT
Created attachment 29481 [details]
Make 2 methods on DOMWindow public
Comment 2 Geoffrey Garen 2009-04-14 18:04:15 PDT
Comment on attachment 29481 [details]
Make 2 methods on DOMWindow public

r=me
Comment 3 Darin Fisher (:fishd, Google) 2009-04-15 11:13:18 PDT
Landed as:  http://trac.webkit.org/changeset/42545