WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
25192
Make DOMWindow:: inlineEventListenerForType public
https://bugs.webkit.org/show_bug.cgi?id=25192
Summary
Make DOMWindow:: inlineEventListenerForType public
Eric Roman
Reported
2009-04-14 17:08:17 PDT
I would like to make these methods of DOMWindow public (currently private): void removeInlineEventListenerForType(const AtomicString& eventType); EventListener* inlineEventListenerForType(const AtomicString& eventType) These used to be public, and live in Document. They were moved in <
http://trac.webkit.org/changeset/42446
>. This change broke chromium which uses the methods in <
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/port/bindings/v8/v8_custom.cpp
>. By making the renamed methods public again, I can easily update v8_custom.cpp to build again. Will attach a patch.
Attachments
Make 2 methods on DOMWindow public
(1.33 KB, patch)
2009-04-14 17:23 PDT
,
Eric Roman
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Roman
Comment 1
2009-04-14 17:23:11 PDT
Created
attachment 29481
[details]
Make 2 methods on DOMWindow public
Geoffrey Garen
Comment 2
2009-04-14 18:04:15 PDT
Comment on
attachment 29481
[details]
Make 2 methods on DOMWindow public r=me
Darin Fisher (:fishd, Google)
Comment 3
2009-04-15 11:13:18 PDT
Landed as:
http://trac.webkit.org/changeset/42545
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug