Bug 251914 - BuilderConverter::convertLineHeight() should not return an std::optional<Length>
Summary: BuilderConverter::convertLineHeight() should not return an std::optional<Length>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-08 04:58 PST by Antoine Quint
Modified: 2023-02-08 12:31 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-02-08 04:58:39 PST 
There is this comment at the end of BuilderConverter::convertLineHeight():

    // FIXME: The parser should only emit the above types, so this should never be reached. We should change the
    // type of this function to return just a Length (and not an Optional).
    return std::nullopt;

Let's fix this!
Comment 1 Antoine Quint 2023-02-08 05:01:10 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9809
Comment 2 EWS 2023-02-08 12:30:04 PST 
Committed 260027@main (c436cfbb0eb0): <https://commits.webkit.org/260027@main>

Reviewed commits have been landed. Closing PR #9809 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-02-08 12:31:20 PST 
<rdar://problem/105187506>