RESOLVED DUPLICATE of bug 251657 251904
EffectiveLang optimization fails when document element is replaced 
https://bugs.webkit.org/show_bug.cgi?id=251904
Summary EffectiveLang optimization fails when document element is replaced
Cameron McCormack (:heycam)
Reported Wednesday, February 8, 2023 6:22:57 AM UTC
If the document element has a lang attribute and it is removed from its parent document node, we can hit the assertion in Element::updateEffectiveLangStateFromParent that checks we don't have a lang attribute. This is because Element::removedFromAncestor checks that the element doesn't have effective lang state before calling updateEffectiveLangStateFromParent(), with the understanding that "no effective lang state" means the element is in the common case of inheriting the document element lang state directly, i.e. there's no intervening ancestor with a lang attribute at all. Additionally, we don't correctly handle updating the document element language when the document element is removed or replaced. (We only update the document element language when the lang attribute on a current document element is changed.)
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 Wednesday, February 8, 2023 6:23:15 AM UTC
<rdar://problem/105163308>
Cameron McCormack (:heycam)
Comment 2 Wednesday, February 8, 2023 7:52:23 PM UTC
*** Bug 251921 has been marked as a duplicate of this bug. ***
Cameron McCormack (:heycam)
Comment 3 Wednesday, February 8, 2023 8:06:13 PM UTC
Original patch in bug 251657 was reverted. I'll use this bug to re-land with these fixes folded in.
Cameron McCormack (:heycam)
Comment 4 Wednesday, February 8, 2023 8:07:07 PM UTC
Actually I can use the original bug. *** This bug has been marked as a duplicate of bug 251657 ***
Note You need to log in before you can comment on or make changes to this bug.