Bug 251847 - run-webkit-tests a/b shouldn't run platform/mac/a/b
Summary: run-webkit-tests a/b shouldn't run platform/mac/a/b
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-07 07:10 PST by Sam Sneddon [:gsnedders]
Modified: 2023-05-17 09:03 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2023-02-07 07:10:42 PST 
Having spoken to a variety of people, there was pretty much uniform agreement that run-webkit-tests shouldn't do any magic path prepending.

Note this does mean, e.g., for `fast/text` you now need to run `run-webkit-tests fast/text platform/*/fast/text` to include the 1 GTK test, 23 Mac tests, 5 iOS tests, or 2 Windows tests.
Comment 1 Sam Sneddon [:gsnedders] 2023-02-07 07:40:59 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9753
Comment 2 Sam Sneddon [:gsnedders] 2023-02-07 10:56:22 PST 
(Changing the summary to actually reflect reality, I clearly wasn't thinking when I typed this—this only affects directories, not paths, because we already don't do this for paths.)
Comment 3 Radar WebKit Bug Importer 2023-02-14 07:11:17 PST 
<rdar://problem/105450444>
Comment 4 EWS 2023-05-17 09:03:11 PDT 
Committed 264151@main (3c10a480a06d): <https://commits.webkit.org/264151@main>

Reviewed commits have been landed. Closing PR #9753 and removing active labels.