Bug 25183 - Split up WebCore.vcproj's settings into vsprops files
Summary: Split up WebCore.vcproj's settings into vsprops files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2009-04-14 08:59 PDT by Adam Roben (:aroben)
Modified: 2009-04-14 11:10 PDT (History)
1 user (show)

See Also:


Attachments
patch + changelog v1 (40.81 KB, patch)
2009-04-14 09:02 PDT, Adam Roben (:aroben)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-04-14 08:59:28 PDT
WebCore.vcproj has become quite bloated, with its large numbers of configurations and settings. Splitting the settings out into separate .vsprops files should make WebCore.vcproj more maintainable, and reduce bloat (since the settings won't have to be duplicated for each confiuration).
Comment 1 Adam Roben (:aroben) 2009-04-14 09:02:15 PDT
Created attachment 29469 [details]
patch + changelog v1
Comment 2 Darin Adler 2009-04-14 10:21:05 PDT
Comment on attachment 29469 [details]
patch + changelog v1

r=me
Comment 3 Steve Falkenburg 2009-04-14 10:38:37 PDT
It would be nice to eliminate the Release_PGO configurations, since I don't think anyone is actively using those.
Comment 4 Adam Roben (:aroben) 2009-04-14 11:06:21 PDT
(In reply to comment #3)
> It would be nice to eliminate the Release_PGO configurations, since I don't
> think anyone is actively using those.

That would be an easy follow-up step. I almost broke out the PGO-specific config options into a WebCorePGO.vsprops, but I suspected that we would be deleting that configuration entirely soon so I didn't bother.
Comment 5 Adam Roben (:aroben) 2009-04-14 11:10:20 PDT
Landed as r42503