WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
251826
[webkitscmpy] Speed up files_changed
https://bugs.webkit.org/show_bug.cgi?id=251826
Summary
[webkitscmpy] Speed up files_changed
Jonathan Bedard
Reported
2023-02-06 17:07:58 PST
The `find` function will require a request or command to convert an argument to a commit object. While that is reasonable in most circumstances, many tools will pass a hash to the files_changed function, which does not need to be converted to a Commit object to be used. Bypass the `find` call if the caller of `files_changed` passed an argument which is obviously a hash.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-02-06 17:24:10 PST
<
rdar://problem/105106632
>
Jonathan Bedard
Comment 2
2023-02-06 17:26:36 PST
Pull request:
https://github.com/WebKit/WebKit/pull/9726
EWS
Comment 3
2023-02-07 08:25:02 PST
Committed
259959@main
(06835af6148a): <
https://commits.webkit.org/259959@main
> Reviewed commits have been landed. Closing PR #9726 and removing active labels.
EWS
Comment 4
2023-02-08 17:20:35 PST
Committed
259548.64@safari-7615-branch
(073b621aaa39): <
https://commits.webkit.org/259548.64@safari-7615-branch
> Reviewed commits have been landed. Closing PR #364 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug