Bug 251826 - [webkitscmpy] Speed up files_changed
Summary: [webkitscmpy] Speed up files_changed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-06 17:07 PST by Jonathan Bedard
Modified: 2023-02-08 17:20 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-02-06 17:07:58 PST
The `find` function will require a request or command to convert an argument to a commit object. While that is reasonable in most circumstances, many tools will pass a hash to the files_changed function, which does not need to be converted to a Commit object to be used. Bypass the `find` call if the caller of `files_changed` passed an argument which is obviously a hash.
Comment 1 Radar WebKit Bug Importer 2023-02-06 17:24:10 PST
<rdar://problem/105106632>
Comment 2 Jonathan Bedard 2023-02-06 17:26:36 PST
Pull request: https://github.com/WebKit/WebKit/pull/9726
Comment 3 EWS 2023-02-07 08:25:02 PST
Committed 259959@main (06835af6148a): <https://commits.webkit.org/259959@main>

Reviewed commits have been landed. Closing PR #9726 and removing active labels.
Comment 4 EWS 2023-02-08 17:20:35 PST
Committed 259548.64@safari-7615-branch (073b621aaa39): <https://commits.webkit.org/259548.64@safari-7615-branch>

Reviewed commits have been landed. Closing PR #364 and removing active labels.