Bug 251750 - Optimize layout of DocumentLoader to reduce padding
Summary: Optimize layout of DocumentLoader to reduce padding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-04 21:06 PST by Simon Fraser (smfr)
Modified: 2023-02-06 13:57 PST (History)
8 users (show)

See Also:

Attachments
Patch (21.52 KB, patch)
2023-02-04 21:19 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (21.87 KB, patch)
2023-02-06 12:17 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (21.87 KB, patch)
2023-02-06 12:18 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2023-02-04 21:06:20 PST 
OpenSource % /usr/bin/python3 ./Tools/Scripts/dump-class-layout -c Release WebCore DocumentLoader   
  +0 <3824> WebCore::DocumentLoader
...
Total byte size: 3824
Total pad bytes: 378
Padding percentage: 9.89 %
Comment 1 Radar WebKit Bug Importer 2023-02-04 21:14:32 PST 
<rdar://problem/105049498>
Comment 2 Simon Fraser (smfr) 2023-02-04 21:19:25 PST 
Created attachment 464844 [details]
Patch
Comment 3 Simon Fraser (smfr) 2023-02-05 17:02:11 PST 
Patch gets it down to:
Total byte size: 3712
Total pad bytes: 285
Comment 4 Simon Fraser (smfr) 2023-02-06 12:17:31 PST 
Created attachment 464869 [details]
Patch
Comment 5 Simon Fraser (smfr) 2023-02-06 12:18:44 PST 
Created attachment 464870 [details]
Patch
Comment 6 EWS 2023-02-06 13:56:57 PST 
Committed 259913@main (7914f5368fed): <https://commits.webkit.org/259913@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464870 [details].