Bug 251715 - Fix build failure in NetworkDataTaskCocoa signposts
Summary: Fix build failure in NetworkDataTaskCocoa signposts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-03 12:10 PST by Ben Nham
Modified: 2023-02-03 12:30 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2023-02-03 12:10:03 PST 
259826@main broke the build due to passing a WTF::String instead of a C string to a logging macro. This was not caught by EWS because the macro does nothing when compiling with the public SDK.
Comment 1 Ben Nham 2023-02-03 12:10:11 PST 
<rdar://problem/105015201>
Comment 2 Ben Nham 2023-02-03 12:11:05 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9620
Comment 3 EWS 2023-02-03 12:30:00 PST 
Committed 259832@main (9c96828e21cd): <https://commits.webkit.org/259832@main>

Reviewed commits have been landed. Closing PR #9620 and removing active labels.