Bug 251674 - [web-animations] clean up the keyframe recomputation code on style change
Summary: [web-animations] clean up the keyframe recomputation code on style change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-03 02:22 PST by Antoine Quint
Modified: 2023-02-03 13:43 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-02-03 02:22:45 PST 
We landed a fair few changes recently to recompute keyframes when style changes while animations are active. The ever-increasing list of parameters added to StyleResolver::keyframeStylesForAnimation() as well as the ever-growing list of change checks made in KeyframeEffectStack::applyKeyframeEffects() should be encapsulated better.
Comment 1 Antoine Quint 2023-02-03 02:37:36 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9591
Comment 2 EWS 2023-02-03 13:42:58 PST 
Committed 259838@main (7a34ce6d9914): <https://commits.webkit.org/259838@main>

Reviewed commits have been landed. Closing PR #9591 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-02-03 13:43:22 PST 
<rdar://problem/105019146>