RESOLVED FIXED251667
Implement a more accurate currentStackPointer().
https://bugs.webkit.org/show_bug.cgi?id=251667
Summary Implement a more accurate currentStackPointer().
Mark Lam
Reported 2023-02-02 22:49:30 PST
currentStackPointer() was already accurate for some ports (the ones that support inline assembly), but for others and when using a Debug build, we fall back to a C runtime function that only gives an approximate value. This patch implements a currentStackPointer() that is accurate for all currently support ports even when using a Debug build.
Attachments
Radar WebKit Bug Importer
Comment 1 2023-02-02 22:49:54 PST
Mark Lam
Comment 2 2023-02-02 23:00:33 PST
EWS
Comment 3 2023-02-03 08:34:11 PST
Committed 259818@main (7dbed20e73b0): <https://commits.webkit.org/259818@main> Reviewed commits have been landed. Closing PR #9585 and removing active labels.
Fujii Hironori
Comment 4 2023-02-05 18:11:26 PST
Bug 251770 – [Win] REGRESSION(259818@main) error LNK2019: unresolved external symbol currentStackPointer
Michael Catanzaro
Comment 5 2023-02-12 05:56:19 PST
OK, this will break Fedora due to missing required architectures ppc64le and s390x, and will likely be worse for Debian since they have tons of architectures. I'll look closer next week, but ideally we would fall back to generic/inaccurate implementation rather than failing to build.
Michael Catanzaro
Comment 6 2023-02-13 14:39:37 PST
I found a simple typo causing the build failure. Fix incoming in bug #252196.
Note You need to log in before you can comment on or make changes to this bug.