Bug 251623 - [media-controls] LayoutTraits.supportsAirPlay() and LayoutTraits.supportPiP() should reliably disable those features
Summary: [media-controls] LayoutTraits.supportsAirPlay() and LayoutTraits.supportPiP()...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-02 11:30 PST by Antoine Quint
Modified: 2023-02-02 11:42 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-02-02 11:30:23 PST 
The way the media controls code deals with LayoutTraits.supportsAirPlay() and LayoutTraits.supportPiP() to disable the relevant features is not ideal since it completely bypasses the MediaSupport classes for them or fails to hide their buttons. The best way to deal with this is to ensure the relevant controls are disabled if the feature is off, ensuring they will not appear anywhere in the UI.
Comment 1 Antoine Quint 2023-02-02 11:34:09 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9547
Comment 2 EWS 2023-02-02 11:41:11 PST 
Committed 259767@main (6aff2cbcaecd): <https://commits.webkit.org/259767@main>

Reviewed commits have been landed. Closing PR #9547 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-02-02 11:42:19 PST 
<rdar://problem/104970740>