WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
251623
[media-controls] LayoutTraits.supportsAirPlay() and LayoutTraits.supportPiP() should reliably disable those features
https://bugs.webkit.org/show_bug.cgi?id=251623
Summary
[media-controls] LayoutTraits.supportsAirPlay() and LayoutTraits.supportPiP()...
Antoine Quint
Reported
2023-02-02 11:30:23 PST
The way the media controls code deals with LayoutTraits.supportsAirPlay() and LayoutTraits.supportPiP() to disable the relevant features is not ideal since it completely bypasses the MediaSupport classes for them or fails to hide their buttons. The best way to deal with this is to ensure the relevant controls are disabled if the feature is off, ensuring they will not appear anywhere in the UI.
Attachments
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2023-02-02 11:34:09 PST
Pull request:
https://github.com/WebKit/WebKit/pull/9547
EWS
Comment 2
2023-02-02 11:41:11 PST
Committed
259767@main
(6aff2cbcaecd): <
https://commits.webkit.org/259767@main
> Reviewed commits have been landed. Closing PR #9547 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-02-02 11:42:19 PST
<
rdar://problem/104970740
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug