RESOLVED FIXED 25159
Support Array.prototype.reduce 
https://bugs.webkit.org/show_bug.cgi?id=25159
Summary Support Array.prototype.reduce
Oliver Hunt
Reported 2009-04-13 13:59:31 PDT
Tracking bug
Attachments
implement reduce (8.36 KB, patch)
2009-04-13 14:33 PDT, Oliver Hunt 		oliver: review-
DetailsFormatted DiffDiff
Performant implementation (11.29 KB, patch)
2009-04-15 15:28 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Reduce redux (12.63 KB, patch)
2009-04-15 16:24 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2009-04-13 14:33:13 PDT
Created attachment 29440 [details] implement reduce
Oliver Hunt
Comment 2 2009-04-13 14:42:56 PDT
Comment on attachment 29440 [details] implement reduce perf is abysmal
Oliver Hunt
Comment 3 2009-04-15 15:28:30 PDT
Created attachment 29519 [details] Performant implementation
Oliver Hunt
Comment 4 2009-04-15 16:24:01 PDT
Created attachment 29521 [details] Reduce redux
Gavin Barraclough
Comment 5 2009-04-15 16:32:17 PDT
Comment on attachment 29521 [details] Reduce redux cachedCall.setArgument(1, array->getIndex(i)); I think this should probably now be: cachedCall.setArgument(1, v);
Oliver Hunt
Comment 6 2009-04-15 16:35:47 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/runtime/ArrayPrototype.cpp M LayoutTests/ChangeLog A LayoutTests/fast/js/array-reduce-expected.txt A LayoutTests/fast/js/array-reduce.html A LayoutTests/fast/js/resources/array-reduce.js Committed r42563
Note You need to log in before you can comment on or make changes to this bug.