Bug 251567 - Move implicit mapping out of CSSPrimitiveValue
Summary: Move implicit mapping out of CSSPrimitiveValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on: 251743
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-01 21:15 PST by Darin Adler
Modified: 2023-02-05 09:41 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2023-02-01 21:15:08 PST 
The feature of CSSPrimitiveValue, where the value can be converted implicitly to various types, can happen by accident. Instead, move this into a separate class. †his frees us up to make some changes to CSSPrimitiveValue itself more easily.
Comment 1 Radar WebKit Bug Importer 2023-02-01 21:44:20 PST 
<rdar://problem/104946191>
Comment 2 Darin Adler 2023-02-01 21:53:50 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9502
Comment 3 EWS 2023-02-04 08:23:07 PST 
Committed 259856@main (de6b51e4e4c6): <https://commits.webkit.org/259856@main>

Reviewed commits have been landed. Closing PR #9502 and removing active labels.
Comment 5 WebKit Commit Bot 2023-02-04 15:46:30 PST 
Re-opened since this is blocked by bug 251743
Comment 6 Darin Adler 2023-02-04 17:59:21 PST 
I’ll fix the crash and re-land.
Comment 7 Darin Adler 2023-02-04 21:55:11 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9656
Comment 8 Darin Adler 2023-02-04 21:58:06 PST 
New pull request has the crash fixed.
Comment 9 EWS 2023-02-05 09:41:31 PST 
Committed 259871@main (3f84cb0e5e03): <https://commits.webkit.org/259871@main>

Reviewed commits have been landed. Closing PR #9656 and removing active labels.