Bug 251558 - Relax the checks of the alpha channel of the blurred stroke in fast/canvas/canvas-scale-strokePath-shadow.html
Summary: Relax the checks of the alpha channel of the blurred stroke in fast/canvas/ca...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-01 15:56 PST by Said Abou-Hallawa
Modified: 2023-02-02 11:34 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-02-01 15:56:18 PST 
This test is a little bit fragile with the system changes which are related to the Gaussian blur stroke. The value of the alpha channel of the stroke can be different on different releases of macOS and iOS. And this why we have three platform expectations for this test.

To make the expectation more robust and to avoid the rebase-lining it in the future, we can relax the text a little and ensure the alpha channel of the blurred stroke is between 75 and 225 instead of 175 and 225.
Comment 1 Said Abou-Hallawa 2023-02-01 15:56:45 PST 
rdar://104761905
Comment 2 Said Abou-Hallawa 2023-02-01 16:02:33 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9491
Comment 3 EWS 2023-02-02 11:34:30 PST 
Committed 259765@main (d538ed723a99): <https://commits.webkit.org/259765@main>

Reviewed commits have been landed. Closing PR #9491 and removing active labels.