Bug 251499 - [css-animations] composite operation of implicit keyframes for CSS Animations should be "replace"
Summary: [css-animations] composite operation of implicit keyframes for CSS Animations...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
: 251498 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-02-01 04:06 PST by Antoine Quint
Modified: 2023-02-01 22:33 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-02-01 04:06:34 PST
The test css/css-animations/KeyframeEffect-getKeyframes.tentative.html was changed recently in https://github.com/web-platform-tests/wpt/commit/1a5c61d2ca9d0f2c2801adf2b433c7931512152f to account for the `animation-composition` property. We need to update our implementation to pass this test, or indicate whether it is incorrect.
Comment 1 Antoine Quint 2023-02-01 05:24:31 PST
*** Bug 251498 has been marked as a duplicate of this bug. ***
Comment 2 Antoine Quint 2023-02-01 07:11:30 PST
So the relevant piece of information here is that getKeyframes() should return "replace" for the "composite" property for implicit keyframes of a CSS Animation, per step 2 of https://drafts.csswg.org/css-animations-2/#keyframes.
Comment 3 Antoine Quint 2023-02-01 07:37:09 PST
Pull request: https://github.com/WebKit/WebKit/pull/9453
Comment 4 Antoine Quint 2023-02-01 07:37:42 PST
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/38297
Comment 5 EWS 2023-02-01 22:27:42 PST
merge-queue failed to commit PR to repository. To retry, remove any blocking labels and re-apply merge-queue label
Comment 6 EWS 2023-02-01 22:32:30 PST
Committed 259739@main (52923169468b): <https://commits.webkit.org/259739@main>

Reviewed commits have been landed. Closing PR #9453 and removing active labels.
Comment 7 Radar WebKit Bug Importer 2023-02-01 22:33:19 PST
<rdar://problem/104947614>