Bug 251450 - Prefix the SVGAnimationElement range setting methods with "set" instead of "calculate"
Summary: Prefix the SVGAnimationElement range setting methods with "set" instead of "c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-31 12:59 PST by Said Abou-Hallawa
Modified: 2023-02-01 11:39 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-01-31 12:59:00 PST 
We need to change the names of these methods:

1) calculateFromAndToValues()
2) calculateFromAndByValues()
3) calculateToAtEndOfDurationValue()

And this will match the names of the SVGAttributeAnimator methods which are called by these methods.
Comment 1 Radar WebKit Bug Importer 2023-01-31 13:00:15 PST 
<rdar://problem/104881126>
Comment 2 Said Abou-Hallawa 2023-01-31 13:05:12 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9401
Comment 3 EWS 2023-02-01 11:39:34 PST 
Committed 259705@main (dd0930cde59d): <https://commits.webkit.org/259705@main>

Reviewed commits have been landed. Closing PR #9401 and removing active labels.