Bug 251439 - [ews-build.webkit.org] Filter out non-reviewer validators
Summary: [ews-build.webkit.org] Filter out non-reviewer validators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-31 08:52 PST by Jonathan Bedard
Modified: 2023-01-31 10:09 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-01-31 08:52:50 PST 
EWS will fail a build if a non-reviewer is the only reviewer. This isn't quite the right approach if the non-reviewer is also a validator, since validators use the "review" flag to validate changes. We should filter out non-reviewer validators from our list of reviewers.
Comment 1 Radar WebKit Bug Importer 2023-01-31 08:53:04 PST 
<rdar://problem/104869860>
Comment 2 Jonathan Bedard 2023-01-31 08:55:10 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9384
Comment 3 EWS 2023-01-31 09:08:15 PST 
Committed 259632@main (13c76085c600): <https://commits.webkit.org/259632@main>

Reviewed commits have been landed. Closing PR #9384 and removing active labels.
Comment 4 Jonathan Bedard 2023-01-31 09:53:28 PST 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/9387
Comment 5 EWS 2023-01-31 10:09:35 PST 
Committed 259633@main (af5a52595279): <https://commits.webkit.org/259633@main>

Reviewed commits have been landed. Closing PR #9387 and removing active labels.