Bug 251251 - Ensure FixedBitVector's WordType matches the type of BitVector::m_bitsOrPointer.
Summary: Ensure FixedBitVector's WordType matches the type of BitVector::m_bitsOrPointer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-26 23:25 PST by Mark Lam
Modified: 2023-01-27 09:08 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-01-26 23:25:50 PST 
The rest of FixedBitVector's code relies on this relationship.  So, let's make it explicit.

Also, fixed a bug in BitMap's API tests: testBitmapConcurrentTestAndSet() and testBitmapConcurrentTestAndClear() were exercising testAndSet() and testAndClear() respectively instead of their concurrent versions.  This was originally found by Yijia Huang in https://bugs.webkit.org/show_bug.cgi?id=250847.
Comment 1 Radar WebKit Bug Importer 2023-01-26 23:26:13 PST 
<rdar://problem/104731974>
Comment 2 Mark Lam 2023-01-26 23:29:54 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9211
Comment 3 EWS 2023-01-27 09:08:28 PST 
Committed 259490@main (c2393f9a46af): <https://commits.webkit.org/259490@main>

Reviewed commits have been landed. Closing PR #9211 and removing active labels.