Bug 251249 - Disambiguate Interpreter::execute() methods.
Summary: Disambiguate Interpreter::execute() methods.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-26 22:51 PST by Mark Lam
Modified: 2023-01-27 00:04 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-01-26 22:51:57 PST
Most Interpreter execute methods already have unique names e.g. executeProgram, executeCall, etc.  The only 2 that are still not disambiguated this way are for eval and cached calls.  Rename these to executeEval and executeCachedCall so that they are more easily grep'able.
Comment 1 Radar WebKit Bug Importer 2023-01-26 22:52:20 PST
<rdar://problem/104730730>
Comment 2 Mark Lam 2023-01-26 23:01:20 PST
Pull request: https://github.com/WebKit/WebKit/pull/9209
Comment 3 EWS 2023-01-27 00:04:35 PST
Committed 259470@main (b63e2e2d251c): <https://commits.webkit.org/259470@main>

Reviewed commits have been landed. Closing PR #9209 and removing active labels.