RESOLVED FIXED 251183
Restrict the set of defaults-overridable flags to better match shipping Safari 
https://bugs.webkit.org/show_bug.cgi?id=251183
Summary Restrict the set of defaults-overridable flags to better match shipping Safari
Brent Fulgham
Reported 2023-01-25 16:06:52 PST
The new feature generator logic attempts to persist all `internal` feature flags such that a developer can use a 'WebKitDebug'-prefix for a setting to override it. This is only desired for a small set of feature flags (those that lived in the Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml file previously). This patch does the following: 1. Corrects a handful of feature flags that were moved from `internal` to `embedder`, improperly. 2. Adds a new key, `defaultsOverridable` to UnifiedWebPreferences.yaml. Flags that have this key with a `true` value will get additional logic to support 'WebKitDebug'-prefix overrides.
Attachments
Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2023-01-25 16:07:06 PST
<rdar://104657361>
Brent Fulgham
Comment 2 2023-01-25 17:03:06 PST
Pull request: https://github.com/WebKit/WebKit/pull/9163
EWS
Comment 3 2023-01-26 15:40:58 PST
Committed 259458@main (0f58ae8a9cfe): <https://commits.webkit.org/259458@main> Reviewed commits have been landed. Closing PR #9163 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.