Bug 251149 - [GTK] Uses deprecated gdk_cairo_draw_from_gl
Summary: [GTK] Uses deprecated gdk_cairo_draw_from_gl
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2023-01-25 06:29 PST by Michael Catanzaro
Modified: 2023-01-25 08:00 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-01-25 06:29:01 PST 
AcceleratedBackingStoreWayland uses gdk_cairo_draw_from_gl, which is documented as "The main way to not draw GL content in GTK."

"""
The function is overly complex and produces broken output in various combinations of arguments. If you want to draw with GL textures in GTK, use gdk_gl_texture_new(); if you want to use that texture in Cairo, use gdk_texture_download() to download the data into a Cairo image surface.
"""

I noticed due to some discussion at Red Hat about how it's currently broken. See https://gitlab.gnome.org/GNOME/gtk/-/issues/5517 where it's not flushing properly.

No clue whether it would be feasible to avoid it or not. I've never attempted to understand graphics.
Comment 1 Carlos Garcia Campos 2023-01-25 06:37:33 PST 
We use gdk_cairo_draw_from_gl() only in GTK3, there's no gdk_gl_texture_new() in GTK3, no?
Comment 2 Michael Catanzaro 2023-01-25 08:00:56 PST 
OK, closing.