Bug 251075 - [GLib] WebKitWebHitTestResult should use composition instead of subclassing
Summary: [GLib] WebKitWebHitTestResult should use composition instead of subclassing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2023-01-24 00:55 PST by Adrian Perez
Modified: 2023-01-31 16:53 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2023-01-24 00:55:06 PST 
While working on issue #251008 we noticed that the WebKitHitTestResult type
cannot be made final because it has a subclass, WebKitWebHitTestResult, in
the injected bundle. More info at

   https://github.com/WebKit/WebKit/pull/8972#issuecomment-1401161473

Ideally, we would prefer that WebKitHitTestResult is actually a final type,
which needs the WebKitWebHitTestResult subclass to use composition instead.
Comment 1 Adrian Perez 2023-01-24 06:00:08 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9036
Comment 2 EWS 2023-01-31 16:52:56 PST 
Committed 259651@main (71df87cb0f48): <https://commits.webkit.org/259651@main>

Reviewed commits have been landed. Closing PR #9036 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-01-31 16:53:22 PST 
<rdar://problem/104892179>