WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 251075
[GLib] WebKitWebHitTestResult should use composition instead of subclassing
https://bugs.webkit.org/show_bug.cgi?id=251075
Summary
[GLib] WebKitWebHitTestResult should use composition instead of subclassing
Adrian Perez
Reported
2023-01-24 00:55:06 PST
While working on issue #251008 we noticed that the WebKitHitTestResult type cannot be made final because it has a subclass, WebKitWebHitTestResult, in the injected bundle. More info at
https://github.com/WebKit/WebKit/pull/8972#issuecomment-1401161473
Ideally, we would prefer that WebKitHitTestResult is actually a final type, which needs the WebKitWebHitTestResult subclass to use composition instead.
Attachments
Add attachment
proposed patch, testcase, etc.
Adrian Perez
Comment 1
2023-01-24 06:00:08 PST
Pull request:
https://github.com/WebKit/WebKit/pull/9036
EWS
Comment 2
2023-01-31 16:52:56 PST
Committed
259651@main
(71df87cb0f48): <
https://commits.webkit.org/259651@main
> Reviewed commits have been landed. Closing PR #9036 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-01-31 16:53:22 PST
<
rdar://problem/104892179
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug