Bug 25106 - Mismatched virtual function signatures in animations
Summary: Mismatched virtual function signatures in animations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL: http://demo.webapp-net.com
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-08 18:18 PDT by Simon Fraser (smfr)
Modified: 2009-04-08 18:34 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.23 KB, patch)
2009-04-08 18:29 PDT, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-04-08 18:18:19 PDT
AnimationBase has 
virtual void endAnimation(bool, double)
and the double is never used.

Everything else has
virtual void endAnimation(bool)

I think this is causing a real bug on http://demo.webapp-net.com, where there's an opacity animation that's never cleaned up.
Comment 1 Simon Fraser (smfr) 2009-04-08 18:29:08 PDT
Created attachment 29353 [details]
Patch
Comment 2 Simon Fraser (smfr) 2009-04-08 18:34:15 PDT
http://trac.webkit.org/changeset/42346