WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
251042
Editing - Code refactoring to avoid several calls to hasEditableStyle() in loop
https://bugs.webkit.org/show_bug.cgi?id=251042
Summary
Editing - Code refactoring to avoid several calls to hasEditableStyle() in loop
Ahmad Saleem
Reported
2023-01-23 14:27:13 PST
Hi Team, I came across this possible merge, which is to avoid looping and reduce calls to hasEditableStyle() in VisibleUnits.cpp: WebKit Source -
https://searchfox.org/wubkat/source/Source/WebCore/editing/VisibleUnits.cpp#1121
&
https://searchfox.org/wubkat/source/Source/WebCore/editing/VisibleUnits.cpp#1178
Blink Commit -
https://chromium.googlesource.com/chromium/blink/+/85355b065acfc6ffbf960afa2d8e175104c556fa
It is just a refactoring to reduce calls, so I think it would be fine to land without any dedicated testcase. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2023-01-24 01:44:40 PST
Committed
259267@main
(e2e91f349dc7): <
https://commits.webkit.org/259267@main
> Reviewed commits have been landed. Closing PR #8993 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2023-01-24 01:45:30 PST
<
rdar://problem/104592394
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug