RESOLVED FIXED 251028
[Cocoa] _WKFeature instances fail bincompat isKindOfClass: check 
https://bugs.webkit.org/show_bug.cgi?id=251028
Summary [Cocoa] _WKFeature instances fail bincompat isKindOfClass: check
Elliott Williams
Reported 2023-01-23 11:58:07 PST
As part of the feature status rollout, we replaced the _WKExperimentalFeature / _WKInternalDebugFeature class dichotomy with a single _WKFeature base class. For bincompat, our legacy endpoints lie about their instance type and declare e.g. an NSArray<_WKExperimentalFeature *>, when the actual instance types are _WKFeature. This matches existing behavior but causes feature instances to fail a isKindOfClass:[_WKExperimentalFeature class] check. If we're going to lie about this, we probably need to lie more completely and override isKindOfClass.
Attachments
Add attachment proposed patch, testcase, etc.
Elliott Williams
Comment 1 2023-01-23 12:02:16 PST
rdar://104543339
Elliott Williams
Comment 2 2023-01-23 12:14:53 PST
Pull request: https://github.com/WebKit/WebKit/pull/8983
EWS
Comment 3 2023-01-23 14:33:05 PST
Committed 259245@main (dd7dffb5b056): <https://commits.webkit.org/259245@main> Reviewed commits have been landed. Closing PR #8983 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.