Bug 25091 - There is no mechanism to register threads.
Summary: There is no mechanism to register threads.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-08 02:32 PDT by Ben Murdoch
Modified: 2009-04-09 13:47 PDT (History)
0 users

See Also:


Attachments
Implements thread registration. (12.95 KB, patch)
2009-04-08 02:37 PDT, Ben Murdoch
no flags Details | Formatted Diff | Diff
Alternative patch after IRC discussion (2.89 KB, patch)
2009-04-09 06:37 PDT, Ben Murdoch
ap: review+
Details | Formatted Diff | Diff
New patch with levin's changes (2.85 KB, patch)
2009-04-09 11:37 PDT, Ben Murdoch
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Murdoch 2009-04-08 02:32:38 PDT
On the Android platform, threads must be registered with the VM before they can run. There is no way in WebKit to perform this registration. I have a patch that implements this functionality on Android and provides empty implementations for other platforms.
Comment 1 Ben Murdoch 2009-04-08 02:37:11 PDT
Created attachment 29328 [details]
Implements thread registration.
Comment 2 Ben Murdoch 2009-04-09 06:37:48 PDT
Created attachment 29366 [details]
Alternative patch after IRC discussion
Comment 3 Alexey Proskuryakov 2009-04-09 06:39:28 PDT
Comment on attachment 29366 [details]
Alternative patch after IRC discussion

Looks fine, r=me.
Comment 4 David Levin 2009-04-09 11:12:37 PDT
Assigned to me for landing.

Asked benm for two changes:
1. s/NULL/0/
2. Switch to c++ style casts.

(which I wanted him to do to verify that the changes built fine for him).

Comment 5 Ben Murdoch 2009-04-09 11:37:55 PDT
Created attachment 29369 [details]
New patch with levin's changes
Comment 6 David Levin 2009-04-09 13:47:08 PDT
Committed <http://trac.webkit.org/changeset/42366>