WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250909
Rename hasTransform() to isTransformed() on RenderObject and RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=250909
Summary
Rename hasTransform() to isTransformed() on RenderObject and RenderLayer
Antoine Quint
Reported
2023-01-20 11:57:19 PST
The name "hasTransform" is kind of convoluted in WebCore due to historically denoting on RenderStyle whether a "transform" property was set to some non-none value. With the addition of more CSS properties affecting transform, and the addition of RenderStyle::affectsTransform(), we should also rename "hasTransform" on RenderLayer and RenderObject to be "isTransformed" to better match what this method denotes.
Attachments
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2023-01-20 11:59:17 PST
Pull request:
https://github.com/WebKit/WebKit/pull/8886
EWS
Comment 2
2023-01-21 09:21:06 PST
Committed
259171@main
(c934d4911662): <
https://commits.webkit.org/259171@main
> Reviewed commits have been landed. Closing PR #8886 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-01-21 10:08:43 PST
<
rdar://problem/104512541
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug