Bug 250879 - Delete unused Windows UA string logic
Summary: Delete unused Windows UA string logic
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-19 17:28 PST by Ahmad Saleem
Modified: 2023-01-26 17:29 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-19 17:28:43 PST 
Hi Team,

While going through Blink's commit, I came cross another clean-up commit, which can be merged into WebKit.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/6d5bdc2b3dc4b675747a86b190fa555c5a018014

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/platform/win/SystemInfo.cpp#80 etc.

Just wanted to raise, so we can track and clean-up some old code and enjoy cleaner WebKit.

Thanks!
Comment 1 Alexey Proskuryakov 2023-01-19 18:39:30 PST 
We do use this function, so probably no easy cleanup:

Source/WebKitLegacy/win/WebView.cpp:    static const NeverDestroyed<String> prefix = makeString("Mozilla/5.0 (", windowsVersionForUAString(), ") AppleWebKit/", webKitVersionString(), " (KHTML, like Gecko)");

Source/WebCore/platform/win/UserAgentWin.cpp:    return makeString("Mozilla/5.0 (", windowsVersionForUAString(), ") AppleWebKit/605.1.15 (KHTML, like Gecko)",
Comment 2 Radar WebKit Bug Importer 2023-01-26 17:29:15 PST 
<rdar://problem/104721654>