RESOLVED INVALID 250879
Delete unused Windows UA string logic 
https://bugs.webkit.org/show_bug.cgi?id=250879
Summary Delete unused Windows UA string logic
Ahmad Saleem
Reported 2023-01-19 17:28:43 PST
Hi Team, While going through Blink's commit, I came cross another clean-up commit, which can be merged into WebKit. Blink Commit - https://chromium.googlesource.com/chromium/blink/+/6d5bdc2b3dc4b675747a86b190fa555c5a018014 WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/platform/win/SystemInfo.cpp#80 etc. Just wanted to raise, so we can track and clean-up some old code and enjoy cleaner WebKit. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2023-01-19 18:39:30 PST
We do use this function, so probably no easy cleanup: Source/WebKitLegacy/win/WebView.cpp: static const NeverDestroyed<String> prefix = makeString("Mozilla/5.0 (", windowsVersionForUAString(), ") AppleWebKit/", webKitVersionString(), " (KHTML, like Gecko)"); Source/WebCore/platform/win/UserAgentWin.cpp: return makeString("Mozilla/5.0 (", windowsVersionForUAString(), ") AppleWebKit/605.1.15 (KHTML, like Gecko)",
Radar WebKit Bug Importer
Comment 2 2023-01-26 17:29:15 PST
<rdar://problem/104721654>
Fujii Hironori
Comment 3 2024-09-24 14:36:24 PDT
Yes, it's used. Closed.
Note You need to log in before you can comment on or make changes to this bug.