WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250870
Remove HTMLMediaElement.webkitHasClosedCaptions/webkitClosedCaptionsVisible
https://bugs.webkit.org/show_bug.cgi?id=250870
Summary
Remove HTMLMediaElement.webkitHasClosedCaptions/webkitClosedCaptionsVisible
Ahmad Saleem
Reported
2023-01-19 16:01:41 PST
Hi Team, While going through Blink's commit, I came across another non-standard removal (replaced by Text Track API), so I thought to raise this bug and get input: Blink Commit -
https://src.chromium.org/viewvc/blink?view=revision&revision=159317
WebKit Source -
https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLMediaElement.cpp#7056
&
https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLMediaElement.idl#98
Just wanted to get input whether it is something worth exploring to clean-up and removal some more code from Webkit while also aiming for standardisation. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-01-19 16:23:17 PST
<
rdar://problem/104451148
>
Karl Dubost
Comment 2
2023-01-19 20:50:22 PST
Yes I believe this can be safely removed. It has no impact on both WPT and Browser Compatibility, but it makes it another opportunity to remove code cruft and another vector for detecting safari.
EWS
Comment 3
2023-09-08 02:38:38 PDT
Committed
267780@main
(0a73c4dbb7a0): <
https://commits.webkit.org/267780@main
> Reviewed commits have been landed. Closing PR #17501 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug