WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250857
Small improvement to VMInspector::dumpRegisters().
https://bugs.webkit.org/show_bug.cgi?id=250857
Summary
Small improvement to VMInspector::dumpRegisters().
Mark Lam
Reported
2023-01-19 12:23:22 PST
When dumping the topCallFrame, we should use numCalleeLocals instead of numVars when we don't know where the next frame is. Using numVars does not give us visibility into all locals that may be in use. Also fix CodeBlock::nameForRegister() to just use VirtualRegister's dumper instead of doing custom and duplicate work.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-01-19 12:23:45 PST
<
rdar://problem/104439794
>
Mark Lam
Comment 2
2023-01-19 12:26:34 PST
Pull request:
https://github.com/WebKit/WebKit/pull/8848
EWS
Comment 3
2023-01-19 13:21:15 PST
Committed
259109@main
(8ad0557c285f): <
https://commits.webkit.org/259109@main
> Reviewed commits have been landed. Closing PR #8848 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug