Bug 250857 - Small improvement to VMInspector::dumpRegisters().
Summary: Small improvement to VMInspector::dumpRegisters().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-19 12:23 PST by Mark Lam
Modified: 2023-01-19 13:21 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-01-19 12:23:22 PST 
When dumping the topCallFrame, we should use numCalleeLocals instead of numVars when we don't know where the next frame is.  Using numVars does not give us visibility into all locals that may be in use.

Also fix CodeBlock::nameForRegister() to just use VirtualRegister's dumper instead of doing custom and duplicate work.
Comment 1 Radar WebKit Bug Importer 2023-01-19 12:23:45 PST 
<rdar://problem/104439794>
Comment 2 Mark Lam 2023-01-19 12:26:34 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8848
Comment 3 EWS 2023-01-19 13:21:15 PST 
Committed 259109@main (8ad0557c285f): <https://commits.webkit.org/259109@main>

Reviewed commits have been landed. Closing PR #8848 and removing active labels.