Bug 250852 - Bail out of networkStateChanged if allPages is NULL
Summary: Bail out of networkStateChanged if allPages is NULL
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-19 10:32 PST by Ahmad Saleem
Modified: 2023-01-19 10:37 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-19 10:32:37 PST 
Hi Team,

While going through Blink's commit, I came across another potential fix, which can fix crashes etc.:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/e6b48197ee2a4eff890eb2cfbb1dcb4a50c75043

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/page/Page.cpp#240

Just wanted to raise to confirm if it is something worth fixing. Unfortunately, it does not have any test case.

Thanks!
Comment 1 Chris Dumez 2023-01-19 10:37:49 PST 
allPages cannot be null in WebKit.