Bug 25085 - Platform layering violations in platform/graphics/MediaPlayer files
Summary: Platform layering violations in platform/graphics/MediaPlayer files
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-07 16:11 PDT by Simon Fraser (smfr)
Modified: 2010-03-23 17:21 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-04-07 16:11:28 PDT 
MediaPlayer.cpp lives in WebCore/platform, yet it knows about FrameView, Frame and Document. This totally breaks the layering that 'platform' is supposed to adhere to.
Comment 1 Dean Jackson 2009-04-07 16:16:00 PDT 
... and MediaDocument, where it tests for that a lot.
Comment 2 Antti Koivisto 2009-04-09 13:10:09 PDT 
The bug title and description are rather overheated. As far as I see all layering violations here are trivial and easily fixable.